feat(button): 버튼 아이콘에도 색상 테마 적용 #44
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
요것 머지해도 될까요?!?!? 버튼 속 아이콘에 색상을 부여하는 PR입니당 |
seojisoosoo
approved these changes
Jan 22, 2024
Comment on lines
+11
to
+12
| LeftIcon?: React.ComponentType<any>; | ||
| RightIcon?: React.ComponentType<any>; |
There was a problem hiding this comment.
누군가가 이것을 .. ComponentType<IconProps>로 수정해주시구 ..... 컨플릭트 해소해주신 후 머지해주신다면 .... 정말 감사하겠습니다!!!!!
Brokyeom
requested review from
Brokyeom,
sohee-K,
jungwoo3490 and
suwonthugger
as code owners
|
📝 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
기존에는 버튼 아이콘에 색상 테마가 적용되지 않았는데, 이제 됩니다!!
스토리북에도 예제를 추가해 두었습니다!!