Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfixes #6

Open
gaya- opened this issue Jul 22, 2016 · 2 comments
Open

Bugfixes #6

gaya- opened this issue Jul 22, 2016 · 2 comments

Comments

@gaya-
Copy link

gaya- commented Jul 22, 2016

Hey,

We used your driver in our teaching project and found some bugs.
I can't make a PR because the commits to make your software work on our robots are mixed with bugfixing commits.
So, here's just a list of commits that you might want to cherry-pick:

8c4513d
8d4054e
0a95f8b

The last commit also includes a possibility to invert the motors, in case they are wired differently. It's an extra feature but it also includes a bugfix. The line 0a95f8b#diff-c00ddbd0620c770bb87191dbe474030cL231 is wrong, you can't use if enc1 in locals() to check if a variable has value. So if you don't want the feature I would at least get rid of this line.

Cheers and thanks for providing this!
Gaya

@doisyg
Copy link

doisyg commented Oct 7, 2016

Is it possible to integrate these commits, that would be really useful!

@sonyccd
Copy link
Owner

sonyccd commented Jan 19, 2017

Please make a pull request

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants