Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Possible feature requests #11

Open
nogweii opened this issue Dec 24, 2023 · 1 comment
Open

Possible feature requests #11

nogweii opened this issue Dec 24, 2023 · 1 comment

Comments

@nogweii
Copy link

nogweii commented Dec 24, 2023

After developing the patterns in #10 , I ran into some things that I'd like to have some more control over, possibly.

1. Some way to control what text is highlighted, not just everything that matches the pattern

This is so that things like the gem or brew prefix don't get highlighted. I'd still like them to be part of the target area. So this is just a cosmetic difference. It's not that big of a deal, but it'd be pretty cool.

2. The ability to pass in a function to build up the URL

I could collapse the two Dockerfile related sections in my other issue if I could control how the URL is built with a function. I could even extend it further and support custom registries fully, by calling a system command to fetch the appropriate URL.

The default version of the function should stick with the current prefix & suffix, it's good enough 90% of the time. This is more of an edge case.

3. The ability to include multiple patterns to match within a file

This is probably pretty hard, from a quick scan through the code. But, being able to include multiple patterns would be a very powerful combo with idea 2.


What do you think? I'm familiar with Lua, so I could take a shot at some of these ideas, but would like your opinion.

@farias-hecdin
Copy link

It would be great if there was a pattern capable of capturing the import statements from github.com in Golang.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants