[Feature][debugcounterorch] Add support for configurable debug drop monitoring feature #3509
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Adds logic to read configuration from DEBUG_DROP_MONITOR - Adds logic to generate syslogs if thresholds are met - Adds logic to toggle the feature off if desired
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
arista-hpandya
changed the title
This was referenced Feb 10, 2025
| if (key == "CONFIG") | ||
| task_status = updateDropMonitorConfig(values); | ||
| } | ||
| catch (const std::runtime_error& e) |
There was a problem hiding this comment.
will this exception be thrown from updateDropMonitorConfig()?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: This change depends on sonic-net/sonic-swss-common#971
Fixes #3501
HLD: sonic-net/SONiC#806
What I did
Why I did it
To implement the persistent drop counter monitoring feature which allows users to configure thresholds for drop counters and receive syslog notifications when those thresholds are exceeded.
How I verified it
make checkto ensure no functionality was affected.Details if related
The configurable drop monitor feature reads the configuration from the DEBUG_DROP_MONITOR table, which includes the status (enabled/disabled), window size, drop count threshold, and incident count threshold. The orchagent periodically polls the drop counters and compares the counts against the configured thresholds. If the thresholds are exceeded, the orchagent generates a syslog message. The feature can be toggled off by setting the status to "disabled" in the DEBUG_DROP_MONITOR table.