[syncd] Add attribute version check feature #1470
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
By default disabled. If enabled, it will use SAI metadata and libsai version returned by sai_api_version_query to verify if given attribute during SAI discovery process was introduced in the current libsai version or below that version. This feature is partial solution to this problem: sonic-net/sonic-buildimage#20725, more here: opencomputeproject/SAI#2099
yxieca
added a commit
to yxieca/sonic-sairedis
that referenced
this pull request
Dec 5, 2024
This reverts commit e6ec142.
yxieca
added a commit
that referenced
this pull request
Dec 6, 2024
Need to keep master branch at SAI header version 1.15 until 202411 branch is cut. 2dbaca8 2024-12-05 | Revert "[submodule] Update SAI to lates origin master ([submodule] Update SAI to latest origin master #1466)" (HEAD -> 202411, yingfork/revert-back-to-1-15) [Ying Xie] 064a3a8 2024-12-05 | Revert "[meta] Use metadata to check port notification port_id type ([meta] Use metadata to check port notification port_id type #1469)" [Ying Xie] 0383740 2024-12-05 | Revert "[syncd] Add attribute version check feature ([syncd] Add attribute version check feature #1470)" [Ying Xie] 0901dd7 2024-12-05 | Revert "[syncd] Introduce VendorSaiOptions class ([syncd] Introduce VendorSaiOptions class #1472)" [Ying Xie]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By default disabled. If enabled, it will use SAI metadata and libsai version returned by sai_api_version_query to verify if given attribute during SAI discovery process was introduced in the current libsai version or below that version.
This feature is partial solution to this problem:
sonic-net/sonic-buildimage#20725, more here: opencomputeproject/SAI#2099