Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement IQ Policy report output for scan #50

Merged
merged 14 commits into from
Jul 22, 2021
Merged

Implement IQ Policy report output for scan #50

merged 14 commits into from
Jul 22, 2021

Conversation

DarthHater
Copy link
Member

@DarthHater DarthHater commented Jul 22, 2021 •
edited
Loading

This adds the IQ Policy Report data, and starts to output it!

This pull request makes the following changes:

  • Adds endpoint in src/iq.rs, also fixes reqwest issue brought on by upgrade of reqwest
  • Adds a function to print the policy_violations, outputting the purl, the policy violations that occurred, and then the inverse dependency graph
  • Removes ptree dependency, as this was a left over of testing some things out with the dependency graph that I forgot to nix, but this work pointed out!

Screen Shot 2021-07-21 at 9 31 49 PM

It relates to the following issue #s:

@DarthHater DarthHater changed the base branch from main to ImproveOSSIndexSupport July 22, 2021 05:05
amy-keibler
amy-keibler approved these changes Jul 22, 2021
View reviewed changes
Copy link
Contributor

@amy-keibler amy-keibler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Left a few change requests that I think make the code a bit clearer, but none of those are things I think should block a merge.

src/bin/iq.rs Outdated Show resolved Hide resolved
NOTICE Outdated Show resolved Hide resolved
src/bin/iq.rs Outdated Show resolved Hide resolved
src/bin/pants.rs Outdated Show resolved Hide resolved
@DarthHater DarthHater merged commit 2073598 into ImproveOSSIndexSupport Jul 22, 2021
@DarthHater DarthHater deleted the PolicyReport branch July 22, 2021 18:09
@DarthHater DarthHater mentioned this pull request Jul 22, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amy-keibler amy-keibler amy-keibler approved these changes

@bhamail bhamail Awaiting requested review from bhamail

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Implement reverse dep tree for IQ
2 participants
@DarthHater @amy-keibler