Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace wrap-type and wrap-length by an unified entry. #19

Open
someth2say opened this issue May 22, 2021 · 2 comments
Open

Replace wrap-type and wrap-length by an unified entry. #19

someth2say opened this issue May 22, 2021 · 2 comments

Comments

@someth2say
Copy link
Owner

What's a little suboptimal in the design of the new setting is that you can now set wrap-type = none + wrap-length = 80 and the outcome will be that the content will not be wrapped. Or wrap-type = sentence + wrap-length = 80 and it will wrap at the end of sentences, even if they're longer than 80 characters. It would be neater if there was a single setting that did not leave such a potential for errors.

@someth2say someth2say changed the title Replace wrap-type and wrap-lenght by an unified entry. Replace wrap-type and wrap-length by an unified entry. May 22, 2021
@fellen
Copy link

fellen commented Jul 6, 2021

Hi, I come from PR #13. after before complaining at opensuse. My problem as a maintainer of https://github.com/Gnucash/gnucash-docs: we have still to support contributors, who have the kitebird version installed.
If I add to

*DEFAULT
  wrap-type = length

that version returns Unknown option name: wrap-type

Perhaps some mapping should be done:
wrap-length = 0 -> wrap-type = none
wrap-length > 0 -> wrap-type = length
and you could add:
wrap-length < 0 -> wrap-type = sentence

@someth2say
Copy link
Owner Author

someth2say commented Jul 7, 2021

Thanks for the request!

I feel you, and I start seeing many people requesting backward compatibility with the Kitebitrd version.
I'm going to re-open #13 and start thinking about different options we may have.

I feel adding extra semantics to wrap-length will be confusing, so I am inclined to consider @sknorr proposal of making length the default wrap-type.
I need to take a deeper look at it and make a decision.

As a side note, I would (indeed) recommend upgrading XMLFormat to this version.
I see your project distributes a copy of Kitebird's version, so just changing it to this one should be enough.
Anyway, I foresee some of your contributors have Kitebird's version installed in their systems, and maybe replacing may be problematic.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants