CalendarVariable::calendar() returns false but expects CalendarModel or null

[danbrellis]

Describe the bug or issue you're experiencing
Solspace\Calendar\Variables\CalendarVariable::calendar() is typed to return either an instance of CalendarModel or null. However, if $calendarService->getCalendars($attributes) returns an empty array, the reset() function will return false.

Steps to Reproduce
This was discovered while using Craft's 1st party plugin Feedme. See craftcms/feed-me#1583 (comment) for steps to reproduce.

Expected Behavior
Solspace\Calendar\Variables\CalendarVariable::calendar() should either be typed to include a return value of false OR convert the potential false value from reset() into null.

Craft & Plugin Info (please complete the following information):

• Craft Version: 5.5.10
• Calendar Version: 5.0.13

[kjmartens]

Sorry about this @danbrellis,

We'll check into this shortly. 🙂