Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

when doing wasme build, the tag/name is not required #58

Open
christian-posta opened this issue Feb 8, 2020 · 1 comment
Open

when doing wasme build, the tag/name is not required #58

christian-posta opened this issue Feb 8, 2020 · 1 comment

Comments

@christian-posta
Copy link
Contributor

when I do a wasme build . then I do a wasme list, I see the following:

ceposta@postamaclab(wasm-hub (master)) $ wasme list
NAME SHA      UPDATED             SIZE   TAGS
     5afbacf2 08 Feb 20 09:21 MST 1.0 MB latest

there is no name.

when I do wasme build --help, I see that "tag is supposed to be required"

  -t, --tag string               The image ref with which to tag this image. Specified in the format <name:tag>. Required

If it's required, we should fail the command if it's not provided. Im wondering if we could do the following, however:

wasme build . --name foo

Then we could default the tag to be something like webassemblyhub.io/foo

unless someone wants to specify the full tag, the can pass in --tag

thoughts?

@christian-posta
Copy link
Contributor Author

mmm on second thought, I suppose we're trying to follow a similar approach to docker?
in that case, let's make -t required and fail the command if not there

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant