-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Envoy image used by deploy envoy
to latest
#213
Comments
As part of the work, we should also print out what default image is used if user chooses to use the default image. I'm not seeing any output in the log that indicates the version atm. |
That's strange, I'm seeing the version when I run it:
Are you seeing a different output? The default image is also currently printed in the help text:
|
You are right @Sodman - sorry I missed it somehow, could be because the huge spaces we have: ~/Downloads/smc-demo wasme deploy envoy webassemblyhub.io/linsununc/add-header:v0.1 23:14:33 |
Tinygo add-header template is failing for old and new versions of envoy:
However, the filter is accepted by gloo 1.8.0, and working, but it shows a lot of errors in the gateway pod:
|
Is your feature request related to a problem? Please describe.
Currently the
wasme deploy envoy
command uses a pretty old version of envoy. Specifically, it uses an old Istio fork of Envoy-wasm based on Envoy 1.15.x with wasm compatability.Describe the solution you'd like
Now that wasm compatability has been merged into upstream envoy, we should be able to use that vanilla envoy for our local
wasme deploy envoy
when users are trying to test their filters locally.Additional context
The default image is stored here, we will also likely need to update docs and tests.
The text was updated successfully, but these errors were encountered: