copy metadata fields on UpsertStatusImmutable (#472)

tjons · web-flow · commit fbf348695281 · 2023-08-08T15:39:22.000Z
* copy metadata fields on UpsertStatusImmutable

* move changelog to latest
diff --git a/changelog/v0.33.0/copy-metadata-on-status-upsert.yaml b/changelog/v0.33.0/copy-metadata-on-status-upsert.yaml
@@ -0,0 +1,4 @@
+changelog:
+  - type: NON_USER_FACING
+    description: >
+      "Copy metadata from the existing object to the upserted object when upserting a status."
diff --git a/pkg/controllerutils/upsert.go b/pkg/controllerutils/upsert.go
@@ -142,6 +142,8 @@ func UpdateStatusImmutable(
 
 	// https://github.com/solo-io/skv2/issues/344
 	copyOfObj.SetUID(existing.GetUID())
+	copyOfObj.SetCreationTimestamp(existing.GetCreationTimestamp())
+	copyOfObj.SetResourceVersion(existing.GetResourceVersion())
 
 	return update(ctx, c, copyOfObj)
 }

Original file line number	Diff line number	Diff line change
`@@ -142,6 +142,8 @@ func UpdateStatusImmutable(`
`142`	`142`
`143`	`143`	`// https://github.com/solo-io/skv2/issues/344`
`144`	`144`	`copyOfObj.SetUID(existing.GetUID())`
	`145`	`+ copyOfObj.SetCreationTimestamp(existing.GetCreationTimestamp())`
	`146`	`+ copyOfObj.SetResourceVersion(existing.GetResourceVersion())`
`145`	`147`
`146`	`148`	`return update(ctx, c, copyOfObj)`
`147`	`149`	`}`