From 6d942c6ea960e92ada72ac9fa8692db2d6e6c8f2 Mon Sep 17 00:00:00 2001 From: Brendan Slabe Date: Fri, 7 Apr 2023 19:04:17 +0200 Subject: [PATCH] Remove actions/cache (#444) * remove cache action * go version file --- .github/workflows/pull_request.yaml | 21 ++++----------------- changelog/v0.29.6/remove-actions-cache.yaml | 5 +++++ 2 files changed, 9 insertions(+), 17 deletions(-) create mode 100644 changelog/v0.29.6/remove-actions-cache.yaml diff --git a/.github/workflows/pull_request.yaml b/.github/workflows/pull_request.yaml index 26061a7aa..ce7a19bf6 100644 --- a/.github/workflows/pull_request.yaml +++ b/.github/workflows/pull_request.yaml @@ -11,20 +11,13 @@ jobs: name: Code Gen runs-on: ubuntu-22.04 steps: + - name: Check out code into the Go module directory + uses: actions/checkout@v3 - name: Set up Go 1.18 uses: actions/setup-go@v4 with: - go-version: 1.18.5 + go-version-file: "go.mod" id: go - - name: Check out code into the Go module directory - uses: actions/checkout@v3 - - uses: actions/cache@v3 - with: - path: ~/go/pkg/mod - key: ${{ runner.os }}-go-${{ hashFiles('**/go.sum') }} - restore-keys: | - ${{ runner.os }}-go- - - name: Generate Code run: | ./ci/check-code-and-docs-gen.sh @@ -36,7 +29,7 @@ jobs: - name: Set up Go 1.18 uses: actions/setup-go@v4 with: - go-version: 1.18.5 + go-version-file: "go.mod" # Required for codegen tests - name: Install kind uses: helm/kind-action@v1.5.0 @@ -49,12 +42,6 @@ jobs: - uses: azure/setup-kubectl@v3 with: version: 'v1.24.7' - - uses: actions/cache@v3 - with: - path: ~/go/pkg/mod - key: ${{ runner.os }}-go-${{ hashFiles('**/go.sum') }} - restore-keys: | - ${{ runner.os }}-go- - name: Install deps for codegen run: | make install-tools diff --git a/changelog/v0.29.6/remove-actions-cache.yaml b/changelog/v0.29.6/remove-actions-cache.yaml new file mode 100644 index 000000000..d0bf3d2b6 --- /dev/null +++ b/changelog/v0.29.6/remove-actions-cache.yaml @@ -0,0 +1,5 @@ +changelog: + - type: NON_USER_FACING + issueLink: https://github.com/solo-io/solo-projects/issues/4708 + resolvesIssue: false + description: Removed actions/cache as this is made redundant by actions/setup-go@v4.