Add svc port fix for sidecar services (#498)

Author: chunter0

changelog/v0.34.2/svc-port-name.yaml

@@ -0,0 +1,5 @@
+changelog:
+  - type: NEW_FEATURE
+    issueLink: https://github.com/solo-io/skv2/issues/488
+    description: >
+      Allow service port names to contain hyphens for sidecar services.

codegen/cmd_test.go

@@ -152,7 +152,7 @@ var _ = Describe("Cmd", func() {
 		Expect(deployment).To(ContainSubstring(fmt.Sprintf("{{ if %s }}", agentConditional)))
 		Expect(deployment).To(ContainSubstring(fmt.Sprintf("{{ if %s }}", "and ($.Values.glooAgent.enabled) (not $.Values.glooAgent.runAsSidecar)")))
 		Expect(deployment).To(ContainSubstring("name: agent-volume"))
-		Expect(deployment).To(ContainSubstring("{{ $glooAgent.ports.grpc }}"))
+		Expect(deployment).To(ContainSubstring(`{{ index $glooAgent "ports" "grpc" }}`))
 		Expect(deployment).To(ContainSubstring("{{ $Values.glooMgmtServer.statsPort }}"))
 	})
 	It("generates controller code and manifests for a proto file", func() {

codegen/templates/chart/operator-deployment.yamltmpl

@@ -297,7 +297,7 @@ spec:
   ports:
   [[- range $port := $container.Service.Ports ]]
   - name: [[ lower $port.Name ]]
-    port: {{ [[ $containerVar ]].ports.[[ $port.Name ]] }}
+    port: {{ index [[ $containerVar ]] "ports" "[[ $port.Name ]]" }}
   [[- end ]]
 {{- end }}
 [[- end ]]

codegen/test/chart/conditional-sidecar/templates/deployment.yaml

@@ -231,7 +231,7 @@ spec:
   type: {{ $glooAgent.serviceType }}
   ports:
   - name: grpc
-    port: {{ $glooAgent.ports.grpc }}
+    port: {{ index $glooAgent "ports" "grpc" }}
 {{- end }}