Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Generalize Comments on Test Container #24

Open
inFocus7 opened this issue Dec 5, 2022 · 0 comments
Open

Generalize Comments on Test Container #24

inFocus7 opened this issue Dec 5, 2022 · 0 comments
Labels
documentation Improvements or additions to documentation good first issue Good for newcomers

Comments

@inFocus7
Copy link
Contributor

inFocus7 commented Dec 5, 2022

Our test_container.go contain many references to http-echo, although it's a general container deployment helper. Example of testrunner, which uses this test_container implementation.

It'll be nice the generalize comments and field names, as to not confuse people into thinking it's echo-specific.
@inFocus7 inFocus7 added documentation Improvements or additions to documentation good first issue Good for newcomers labels Dec 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
documentation Improvements or additions to documentation good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@inFocus7