Introduce package command #58
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Akasurde
reviewed
Jan 13, 2022
EItanya
reviewed
Jan 13, 2022
EItanya
reviewed
Jan 13, 2022
EItanya
reviewed
Jan 13, 2022
| @@ -0,0 +1,8 @@ | |||
| FROM alpine:3.14 | |||
There was a problem hiding this comment.
Any reason not to just call this Dockerfile? There's only one in this directory
There was a problem hiding this comment.
Purely for being explicit to its purpose as well ease of finding it since there are other Dockerfiles in the repo.
Happy to change it, what do you think?
EItanya
requested changes
Jan 14, 2022
| @@ -0,0 +1,151 @@ | |||
| package packageCmd | |||
There was a problem hiding this comment.
nit: should be named package just like the rest of the cmd packages
There was a problem hiding this comment.
I agree! but it can't be because package is a reserved word; package package
There was a problem hiding this comment.
Then package_cmd, and have the dir named package?
EItanya
approved these changes
Jan 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduces
bee packagecommand to package built BPF programs in the local registry along withbeein a single, runnable docker image that can ran as a container (as long as there are sufficient permissions)fixes #41