Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[admin] Build the admin CSS before running the specs #5558

Merged
merged 2 commits into from
Dec 19, 2023
Merged

[admin] Build the admin CSS before running the specs #5558

merged 2 commits into from
Dec 19, 2023

Conversation

elia
Copy link
Member

@elia elia commented Dec 19, 2023

Summary

Ensure we test the admin (also for accessibility, contrast, etc.) with styles applied.

Checklist

Check out our PR guidelines for more details.

The following are mandatory for all PRs:

The following are not always needed:

  • 📖 I have updated the README to account for my changes.
  • 📑 I have documented new code with YARD.
  • 🛣️ I have opened a PR to update the guides.
  • ✅ I have added automated tests to cover my changes.
  • 📸 I have attached screenshots to demo visual changes.

@elia elia self-assigned this Dec 19, 2023
@elia elia marked this pull request as ready for review December 19, 2023 16:17
@elia elia requested a review from a team as a code owner December 19, 2023 16:17
@elia elia merged commit ebd123a into main Dec 19, 2023
8 checks passed
@elia elia deleted the elia/admin/tw-spec branch December 19, 2023 16:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rainerdema rainerdema rainerdema approved these changes

Assignees

@elia elia

Labels
changelog:solidus_admin
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@elia @rainerdema