Update samples to match new SSF style #5437
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
changelog:solidus_sample
jarednorman
approved these changes
Oct 13, 2023
|
@aleph1ow I'm a bit worried about some images having different sizes. Could that be an issue in other parts of the storefront, like the cart or the checkout? |
kennyadsl
force-pushed
the
paolotatone/update-samples
branch
from
752ea0b to
2d0bbb3
Compare
elia
approved these changes
Dec 19, 2023
|
We checked manually, everything seems fine ✨ |
spaghetticode
added a commit
to nebulab/solidus
that referenced
this pull request
Feb 2, 2024
We vastly reworked sample products data with #solidusio/pull/5437 After these changes, a few products with variants remained without option types, meaning that their variants were not visible on the FE, and in the admin it was not possible to add new ones.
spaghetticode
added a commit
to nebulab/solidus
that referenced
this pull request
Feb 2, 2024
Sample products data was reworked with #solidusio/pull/5437. After these changes, some products with variants remained without option types, meaning that their variants remained not visible and selectable on the FE, and in the admin it was not possible to add new ones as the relevant button was hidden.
3 tasks
spaghetticode
added a commit
to nebulab/solidus
that referenced
this pull request
Feb 2, 2024
Sample products data was reworked with solidusio/pull/5437. After these changes, some products with variants remained without option types, meaning that their variants remained not visible and selectable on the FE, and in the admin it was not possible to add new ones as the relevant button was hidden.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Solidus Starter Frontend is going to be updated with the new styles applied to the demo.solidus.io.
To do that the new set of samples needs to be brought into solidus.
We'll probably release this one in parallel with SSF update. In any case, if you'd load the new samples into the current SSF version you'll see this. Not a big deal.
Checklist
Check out our PR guidelines for more details.
The following are mandatory for all PRs:
The following are not always needed: