[Admin] Table component rows do not contain links #5944
Comments
|
@MadelineCollier @solidusio/core-team I would like this to be addressed before we continue to implement more and more admin code like this. WDYT? |
|
Yep I can take a look at this before the end of this week! @tvdeyen |
MadelineCollier
added a commit
to MadelineCollier/solidus
that referenced
this issue
Nov 25, 2024
All over the new admin we use divs or simply text to display the resource and rely on a complex Stimulus click event handler to open the edit route. This is not semantic at all and makes it necessary to use a fully JS enabled browser under all circumstances to test the new admin interface which leads to flaky and slow tests. We should use links instead and probably remove the stimulus click event handler. Also, links are not visually highlighted, which leads to a11y issues. solidusio#5944
3 tasks
MadelineCollier
added a commit
to MadelineCollier/solidus
that referenced
this issue
Nov 27, 2024
All over the new admin we use divs or simply text to display the resource and rely on a complex Stimulus click event handler to open the edit route. This is not semantic at all and makes it necessary to use a fully JS enabled browser under all circumstances to test the new admin interface which leads to flaky and slow tests. We should use links instead and probably remove the stimulus click event handler. Also, links are not visually highlighted, which leads to a11y issues. So, this commit adds underlines to links in table rows. solidusio#5944
MadelineCollier
added a commit
to MadelineCollier/solidus
that referenced
this issue
Nov 27, 2024
All over the new admin we use divs or simply text to display the resource and rely on a complex Stimulus click event handler to open the edit route. This is not semantic at all and makes it necessary to use a fully JS enabled browser under all circumstances to test the new admin interface which leads to flaky and slow tests. We should use links instead and probably remove the stimulus click event handler. Also, links are not visually highlighted, which leads to a11y issues. So, this commit adds underlines to links in table rows. solidusio#5944
MadelineCollier
added a commit
to MadelineCollier/solidus
that referenced
this issue
Nov 27, 2024
All over the new admin we use divs or simply text to display the resource and rely on a complex Stimulus click event handler to open the edit route. This is not semantic at all and makes it necessary to use a fully JS enabled browser under all circumstances to test the new admin interface which leads to flaky and slow tests. We should use links instead and probably remove the stimulus click event handler. Also, links are not visually highlighted, which leads to a11y issues. So, this commit adds underlines to links in table rows. solidusio#5944
|
See #6105 for what we would need to do in order to make this a success. |
This was referenced Dec 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
All over the new admin we use divs or simply text to display the resource and rely on a complex Stimulus click event handler to open the edit route. This is not semantic at all and makes it necessary to use a fully JS enabled browser under all circumstances to test the new admin interface which leads to flaky and slow tests.
We should use links instead and probably remove the stimulus click event handler. Also, links are not visually highlighted, which leads to a11y issues.
The text was updated successfully, but these errors were encountered: