Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Solidus dependancy on paperclip makes it incompatible with ruby 3.0 #3993

Closed
iqre8 opened this issue Mar 14, 2021 · 6 comments
Closed

Solidus dependancy on paperclip makes it incompatible with ruby 3.0 #3993

iqre8 opened this issue Mar 14, 2021 · 6 comments

Comments

@iqre8
Copy link

iqre8 commented Mar 14, 2021

https://github.com/solidusio/solidus/blob/master/frontend/app/views/spree/shared/_image.html.erb#L5 causes an error. It indicates undefined method `escape' for URI:Module

Solidus Version:
Spree.solidus_version 2.11.5
solidus_frontend 2.11.5
paperclip 6.1.0

To Reproduce
I don't seem to have task sandbox

Current behavior

Expected behavior
I expected a shop to be visible.

Screenshots
Capture1

Desktop (please complete the following information):

  • OS: Windows 10
  • Browser Firefox 86.0 (64-bit)

Additional context

A pull request has been created @ paperclip:
thoughtbot/paperclip#2676

@jarednorman
Copy link
Member

I'm on my phone at this moment, but if I remember correctly we are moving to the maintained fork of paperclip with the next release.

@iqre8
Copy link
Author

iqre8 commented Mar 15, 2021

What's the solution if I wanna stay on stable? Downgrade ruby to 2.7.2?

@jarednorman
Copy link
Member

Yeah, for now 2.11 doesn't support Ruby 3.0.

@filippoliverani
Copy link
Contributor

filippoliverani commented Mar 19, 2021

What's the solution if I wanna stay on stable? Downgrade ruby to 2.7.2?

Another solution could be switching to ActiveStorage.
If your application is already running on Rails >= 6.1, you can migrate any existing Paperclip uploads with a task like this (could need some updates for Rails 6.1) and change AppConfiguration#image_attachment_module and AppConfiguration#taxon_attachment_module settings.

An alternative but much more complex approach would be writing and registering your own image_attachment and taxon_attachment modules, with your custom attachment management implementation.

@zernie
Copy link

zernie commented Sep 5, 2021

@filippoliverani I'm not even using paperclip, but solidus 3.0 still depends on kt-paperclip. Does solidus support ruby 3.0 & Rails 6.1?

@kennyadsl
Copy link
Member

This has been addressed now. Solidus depends on kt-paperclip.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants