Skip to content

Commit e4b2c66

Browse files
committed
fix missing disposal of nested transition nodes
1 parent 30725b2 commit e4b2c66

File tree

2 files changed

+10
-5
lines changed

2 files changed

+10
-5
lines changed

.changeset/weak-fishes-wait.md

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
1+
---
2+
"solid-js": patch
3+
---
4+
5+
fix missing disposal of nested transition nodes

packages/solid/src/reactive/signal.ts

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1654,12 +1654,12 @@ function cleanNode(node: Owner) {
16541654
}
16551655
}
16561656

1657+
if ((node as Memo<any>).tOwned) {
1658+
for (i = (node as Memo<any>).tOwned!.length - 1; i >= 0; i--)
1659+
cleanNode((node as Memo<any>).tOwned![i]);
1660+
delete (node as Memo<any>).tOwned;
1661+
}
16571662
if (Transition && Transition.running && (node as Memo<any>).pure) {
1658-
if ((node as Memo<any>).tOwned) {
1659-
for (i = (node as Memo<any>).tOwned!.length - 1; i >= 0; i--)
1660-
cleanNode((node as Memo<any>).tOwned![i]);
1661-
delete (node as Memo<any>).tOwned;
1662-
}
16631663
reset(node as Computation<any>, true);
16641664
} else if (node.owned) {
16651665
for (i = node.owned.length - 1; i >= 0; i--) cleanNode(node.owned[i]);

0 commit comments

Comments
 (0)