This repository has been archived by the owner on Apr 13, 2022. It is now read-only.

Fix response.exists() logic #71

Open

dmitrizagidulin opened this issue Mar 28, 2016 · 1 comment

Contributor

dmitrizagidulin commented Mar 28, 2016

Currently, response.exists() will never return false (since the web.solidRequest() method returns an error object when status < 300). Fix this.

The text was updated successfully, but these errors were encountered:

Contributor

elf-pavlik commented Oct 17, 2016 •

edited

Loading

same applies to solidResponse.xhr.status === 403 suggested in https://github.com/solid/solid-client#getting-information-about-a-resource

responsible code in solid-web-client : https://github.com/solid/solid-web-client/blob/f7c9f2e673bc956c67fcee091beaeebfc35687d9/src/client.js#L312-L318

dmitrizagidulin mentioned this issue

Do not reject() http requests on 404 not found solid-contrib/solid-web-client#4

Open

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.