Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve FedCM Fallback for Unsupported Browsers #67

Open
thhck opened this issue Jan 16, 2025 · 1 comment
Open

Improve FedCM Fallback for Unsupported Browsers #67

thhck opened this issue Jan 16, 2025 · 1 comment

Comments

@thhck
Copy link
Collaborator

thhck commented Jan 16, 2025

Currently, if a user attempts to use our IDP’s FedCM feature on an unsupported browser (or without the necessary flags enabled ), they encounter errors. We want to handle these cases more gracefully by detecting unsupported environments and/or hiding FedCM options entirely . This way, users do not see confusing error messages that might lead them to think the system is broken.

I'm thinking to hide the "Register IdP to FedCM" button from the login page. If the browser have the IdentityProvider API available, we just trigger the register function ( withtout asking the user to click the button ) , otherwise we dont.

related: #66

@michielbdejong
Copy link
Collaborator

Or:

  • if the user is not using Chrome, show 'switch to Chrome if you want to benefit from FedCM'
  • if the user is using Chrome but doesn't have the flags enabled, show 'enable these flags if you want to benefit from FedCM'
  • if the user is using Chrome with the flags enabled, show the button as it looks now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants