Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Able to resize a panel beyond collapse button #207

Open
ross-moug opened this issue Apr 6, 2021 · 2 comments
Open

Able to resize a panel beyond collapse button #207

ross-moug opened this issue Apr 6, 2021 · 2 comments

Comments

@ross-moug
Copy link

ross-moug commented Apr 6, 2021

Describe the bug
When using a Panel component which is resizable then the user can shrink the side pane to beyond the side pane header's width (including the collapse button).

Setting panelMinSize would solve this but we are using this in a generic way so we'd like to be able to set the min-width of the Panel (or the panelMinSize) dynamically based on the header content.

To Reproduce
Steps to reproduce the behaviour:

  1. Go to the Nova docs
  2. Scroll to the "Enabling Resizability" example
  3. Manually change the header text via Dev tools to a string which is longer than 150px
  4. Click and drag the side pane

Expected behaviour
The side pane prevents the user resizing it below the minimum width of the side header (including the collapse button).

Screenshots
Clicking and dragging pane boundary
image-2021-03-31-14-46-22-163

Click and drag released
image-2021-03-31-14-46-54-247

Dev tools showing resizer min-width
MicrosoftTeams-image (5)

Environment (please complete the following information):

  • OS: MacOS Catalina
  • Browser Chrome
  • Browser 89

Additional context
We have currently hit this issue on Nova 9 so a workaround, if available, would be appreciated until we can upgrade to Nova 11 (and Angular 11).

@ross-moug ross-moug changed the title Able to resize a panel beyond collapse button (Nova 9) Able to resize a panel beyond collapse button Apr 6, 2021
@ross-moug
Copy link
Author

If you can access N-able repos, here is a proposed solution to workaround this issue on Nova 9: https://github.com/logicnow/msp-entity-module/compare/bugfix/RMM-40300_preventSidePaneShrinkingBelowHeaderMinWidth.

@ewok-janitor
Copy link
Contributor

ewok-janitor commented Apr 7, 2021

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants