PRIVMSG NickServ messages are not echoed

[progval]

:osmium.libera.chat NOTICE * :*** Checking Ident
:osmium.libera.chat NOTICE * :*** Looking up your hostname...
:osmium.libera.chat NOTICE * :*** No Ident response
:osmium.libera.chat NOTICE * :*** Found your hostname: [redacted]
CAP LS 302
:osmium.libera.chat CAP * LS :account-notify away-notify chghost extended-join multi-prefix sasl=ECDSA-NIST256P-CHALLENGE,EXTERNAL,PLAIN,SCRAM-SHA-512 tls account-tag cap-notify echo-message server-time solanum.chat/identify-msg solanum.chat/oper solanum.chat/realhost
CAP REQ :echo-message 
:osmium.libera.chat CAP * ACK :echo-message
NICK valtest
USER f f f f
CAP END
:osmium.libera.chat 001 valtest :Welcome to the Libera.Chat Internet Relay Chat Network valtest
[...]
:osmium.libera.chat 376 valtest :End of /MOTD command.
:valtest MODE valtest :+Ziw

PRIVMSG NickServ :HELP
:[email protected] NOTICE valtest :***** NickServ Help *****
[...]
:[email protected] NOTICE valtest :***** End of Help *****

however, PRIVMSG to regular users does show an echo:

PRIVMSG val :test
:valtest!~f@[redacted] PRIVMSG val :test

[DasBrain]

Someone reported something similar on hackint. It echo-message doesn't work there if a user on a solanum server messages a user on charybdis.

This might as well an atheme bug.

[jillest]

The consistent approach would be to generate an ECHO message back when the next server to send the PRIVMSG or NOTICE to does not support the ECHO capab. This would make servers without ECHO capab work as well as possible and justifies the existence of the capab.

[aaronmdjones]

There's also the problem of remote servers not knowing about what capabilities a client has enabled.

[jillest]

There's also the problem of remote servers not knowing about what capabilities a client has enabled.

The current code handles that by unconditionally sending back an ECHO message server-to-server and checking client capabilities only for a local client. This works, but the server-to-server ECHO messages are a bit wasteful.