Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

middle parameters are not sanitized #295

Open
slingamn opened this issue Nov 5, 2021 · 2 comments
Open

middle parameters are not sanitized #295

slingamn opened this issue Nov 5, 2021 · 2 comments

Comments

@slingamn
Copy link

slingamn commented Nov 5, 2021

Sorry if this is a duplicate. Testing just now, this is a normal 403 ERR_NOSUCHCHANNEL, with three parameters (nickname, channel name, and human-readable description):

TOPIC #nonexistentchannel
:tungsten.libera.chat 403 slingamn__ #nonexistentchannel :No such channel

But this one has two parameters:

TOPIC ::
:tungsten.libera.chat 403 slingamn__ : :No such channel

and this one has four:

TOPIC :#nonexistent channel
:tungsten.libera.chat 403 slingamn__ #nonexistent channel :No such channel

I've been sending * in this case, which is not necessarily the right answer:

https://github.com/ergochat/ergo/blob/2274ef3fa05c2b99372ecfc28f4ddb06677b5746/irc/utils/args.go#L33-L40

Thanks for your time.

@jesopo
Copy link
Member

jesopo commented Jan 6, 2022

is there a generalised "malformed data" numeric

@SadieCat
Copy link
Contributor

SadieCat commented Feb 1, 2022

What InspIRCd does in this case is we just send * in place of the malformed parameter.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants