bug: 0.0041 * LAMPORTS_PER_SOL

[EdogawaDenji]

0.0041 * LAMPORTS_PER_SOL equal to 4100000.0000000005?

RangeError: The number 4100000.0000000005 cannot be converted to a BigInt because it is not an integer

[buffalojoec]

That's weird. The math should evaluate to 4_100_000.

/**
 * There are 1-billion lamports in one SOL
 */
export const LAMPORTS_PER_SOL = 1000000000;

Do you have some repro code?

[lorisleiva]

That's just IEEE 754 maths I'm afraid.

https://www.typescriptlang.org/play?#code/MYewdgziA2CmB00QHMAUAGe70BYCMABAFQF4D626F216AlEA

I'd recommend never using floating points for handling financial values.

[github-actions]

Hi @EdogawaDenji,

Thanks for your question!

We want to make sure to keep signal strong in the GitHub issue tracker – to make sure that it remains the best place to track issues that affect the development of the Solana JavaScript SDK itself.

Questions like yours deserve a purpose-built Q&A forum. Unless there exists evidence that this is a bug with the Solana JavaScript SDK itself, please post your question to the Solana Stack Exchange using this link: https://solana.stackexchange.com/questions/ask

---

This automated message is a result of having added the ‘question’ tag.

[steveluscher]

You will like what we're working on – a set of utilities to make annoying math like this possible on fixed-point integers. Follow along in solana-labs/web3.js-issue-conveyer#21.

[github-actions]

Because there has been no activity on this issue for 7 days since it was closed, it has been automatically locked. Please open a new issue if it requires a follow up.