Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[nextjs] mobile friendly header #32

Closed
nickfrosty opened this issue Jan 24, 2024 · 10 comments
Closed

[nextjs] mobile friendly header #32

nickfrosty opened this issue Jan 24, 2024 · 10 comments
Assignees
Labels
bug Something isn't working enhancement New feature or request example needed We need an example repo that shows the issue or new feature good first issue Good for newcomers

Comments

@nickfrosty
Copy link
Member

the generated nextjs app is not mobile friendly. specifically, the header and links. when the screen size gets too small, the UI breaks.

Generator used:

  • NextJS with tailwind

note: this might also apply to the react app too. I have not yet checked.

@nickfrosty nickfrosty added bug Something isn't working enhancement New feature or request labels Jan 24, 2024
@beeman beeman self-assigned this Jan 29, 2024
@beeman beeman added the good first issue Good for newcomers label Jan 29, 2024
@kaksv
Copy link

kaksv commented Feb 6, 2024

Can i also contribute to this?

@beeman
Copy link
Collaborator

beeman commented Feb 6, 2024

Can i also contribute to this?

For sure, feel free to submit a PR that fixes this.

There is a contributing guide in the repo to help you set it up.

Alternatively you could scaffold a new project, make the changes and push it up to Github and I will merge them back into the templates.

@kaksv
Copy link

kaksv commented Feb 7, 2024 via email

@kaksv
Copy link

kaksv commented Feb 7, 2024

@beeman though I am good with the nextjs, tailwind and css, I am finding issues with Nx, any quick recommendation for farmiliarizing myself with it would be great. Otherwise I am failing to run it locally and see my changes.

@beeman
Copy link
Collaborator

beeman commented Feb 7, 2024

@beeman though I am good with the nextjs, tailwind and css, I am finding issues with Nx, any quick recommendation for farmiliarizing myself with it would be great. Otherwise I am failing to run it locally and see my changes.

If you have tried using the steps described here and get stuck, feel free to send me a message on Discord (linked in my GitHub profile) and I can see where specifically our docs need clarification.

Alternatively, you can make the changes in a generated project and push that up to a new repo and I'll merge them in.

@beeman beeman added the example needed We need an example repo that shows the issue or new feature label Mar 26, 2024
@Afoxcute
Copy link

@nickfrosty @beeman Is this issue still open for contribution?

@beeman
Copy link
Collaborator

beeman commented Dec 29, 2024

@nickfrosty @beeman Is this issue still open for contribution?

It is! That said, any effort should probably go into the new iteration of the templates, based on @solana/web3.js v2.

Feel free to create a pull request that makes the header responsive in this new work-in-progress template.

@Afoxcute
Copy link

@nickfrosty @beeman Is this issue still open for contribution?

It is! That said, any effort should probably go into the new iteration of the templates, based on @solana/web3.js v2.

Feel free to create a pull request that makes the header responsive in this new work-in-progress template.

Can you point me to the contribution guide?

@beeman
Copy link
Collaborator

beeman commented Dec 30, 2024

@nickfrosty @beeman Is this issue still open for contribution?

It is! That said, any effort should probably go into the new iteration of the templates, based on @solana/web3.js v2.
Feel free to create a pull request that makes the header responsive in this new work-in-progress template.

Can you point me to the contribution guide?

It looks like you found it! I'll create a guide in this repo though!

@beeman
Copy link
Collaborator

beeman commented Jan 2, 2025

Thanks to @Afoxcute the new version of the templates will have a header that's mobile-friendly!

@beeman beeman closed this as completed Jan 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request example needed We need an example repo that shows the issue or new feature good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

4 participants