-
Notifications
You must be signed in to change notification settings - Fork 121
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[nextjs] mobile friendly header #32
Comments
Can i also contribute to this? |
For sure, feel free to submit a PR that fixes this. There is a contributing guide in the repo to help you set it up. Alternatively you could scaffold a new project, make the changes and push it up to Github and I will merge them back into the templates. |
Alright, let me do so.
…On Wed, Feb 7, 2024, 2:48 AM beeman ***@***.***> wrote:
Can i also contribute to this?
For sure, feel free to submit a PR that fixes this.
There is a contributing guide in the repo to help you set it up.
Alternatively you could scaffold a new project, make the changes and push
it up to Github and I will merge them back into the templates.
—
Reply to this email directly, view it on GitHub
<#32 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AIMXREINJGVII7MI2OJKUCLYSK6MBAVCNFSM6AAAAABCJKZP5CVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSMZQHE3DCOBVHA>
.
You are receiving this because you commented.Message ID:
***@***.***>
|
@beeman though I am good with the nextjs, tailwind and css, I am finding issues with Nx, any quick recommendation for farmiliarizing myself with it would be great. Otherwise I am failing to run it locally and see my changes. |
If you have tried using the steps described here and get stuck, feel free to send me a message on Discord (linked in my GitHub profile) and I can see where specifically our docs need clarification. Alternatively, you can make the changes in a generated project and push that up to a new repo and I'll merge them in. |
@nickfrosty @beeman Is this issue still open for contribution? |
It is! That said, any effort should probably go into the new iteration of the templates, based on Feel free to create a pull request that makes the header responsive in this new work-in-progress template. |
Can you point me to the contribution guide? |
It looks like you found it! I'll create a guide in this repo though! |
Thanks to @Afoxcute the new version of the templates will have a header that's mobile-friendly! |
the generated nextjs app is not mobile friendly. specifically, the header and links. when the screen size gets too small, the UI breaks.
Generator used:
note: this might also apply to the react app too. I have not yet checked.
The text was updated successfully, but these errors were encountered: