Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RFE] Include optional extra dependencies in reqcheck #175

Open
amoralej opened this issue Jul 30, 2019 · 1 comment
Open

[RFE] Include optional extra dependencies in reqcheck #175

amoralej opened this issue Jul 30, 2019 · 1 comment

Comments

@amoralej
Copy link
Contributor

Currently, reqcheck only compares requirements in requirements.txt file to Requires in the spec file.

It'd be also good to report optional dependencies (probably disabled by default by could be enabled with some cli option) to also include optional dependencies included in setup.cfg as extras. An example of implementation from RDO maintainer in:

https://github.com/jdennis/tools/blob/master/validate-python-deps-in-rpm#L222-L242

@apevec
Copy link
Contributor

apevec commented Oct 23, 2019

There are also optional deps in unexpected places e.g. in Ironic Agent https://opendev.org/openstack/ironic-python-agent/src/branch/master/plugin-requirements.txt

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants