Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Import ABC from collections.abc instead of collections for Python 3.9 compatibility #6

Closed
wants to merge 1 commit into from
Closed

Import ABC from collections.abc instead of collections for Python 3.9 compatibility #6

wants to merge 1 commit into from

Conversation

tirkarthi
Copy link
Contributor

Fixes #5

@javierpena
Copy link
Contributor

Hi!

Thanks for your patch. We are not using GitHub PRs in this repository, but instead use a Gerrit instance in https://softwarefactory-project.io . Do you mind if I take your patch and send it there?

Thanks,
Javier

@tirkarthi
Copy link
Contributor Author

Sure, feel free to use the patch.

@javierpena
Copy link
Contributor

Thanks! I've moved it to https://softwarefactory-project.io/r/17448

@javierpena javierpena closed this Feb 6, 2020
sf-project-io pushed a commit that referenced this pull request Apr 2, 2020
@tirkarthi @javierpena
Import ABC from collections.abc instead of collections
8ff15a9 
For Python 3.9 compatibility.

Comes from #6

Change-Id: Ic34b7bf5857b863cd30371ea475b084c9a00cd65
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Importing ABC directly from collections module was removed in Python 3.9
2 participants
@tirkarthi @javierpena