fix: react-native-windows implementation for new architecture #2527
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marlenecota
reviewed
Nov 8, 2024
marlenecota
reviewed
Nov 8, 2024
marlenecota
reviewed
Nov 8, 2024
marlenecota
reviewed
Nov 8, 2024
marlenecota
reviewed
Nov 8, 2024
marlenecota
approved these changes
Nov 8, 2024
jakex7
approved these changes
Nov 13, 2024
There was a problem hiding this comment.
Thank you @acoates-ms for contribution 🎉 I just left a small suggestion
jakex7
changed the title
|
Hey @acoates-ms, it looks like the CI for |
Oops, I accidently left an Office specific change in the PR, which broke the CI. Should be fixed now. I also brought in latest fixes from react-native-windows to deal with some issues we were having with the new arch and cloning custom props objects. |
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
There are two main things going on with the PR. Both involve a reworking of the new arch implementation of rn-svg for windows.
The current implementation attempts to implement a svg renderer from scratch. There are numerous edge cases that it wasn't handling correctly, and the performance had some serious issues. This implementation switches to use the svg rendering path built into Direct2D. This brings significant performance improvements.
The 2nd issue is there have been various breaking changes in react-native-windows for how new arch native components are implemented. This brings the rn-svg implementation in line with those latest changes.
Test Plan
Primary testing right now is loading up the example app in the repo.
New arch on react-native-windows is still in somewhat early days - so there are not really current users of this code. I am integrating this code into Microsoft Office, where I have tested some scenarios. But we will get expanded testing as we roll out the new arch. I expect there to be some follow-ups as we expand our usage. The version of rn-svg before this PR doesn't build with the latest new arch react-native-windows versions. - So its hard to get worse than that.
What's required for testing (prerequisites)?
What are the steps to reproduce (after prerequisites)?
Compatibility
Checklist
README.md__tests__folder