-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unable to build for macOS with new arch enabled #2192
Comments
Same problem in
|
Hi, thank you for reporting this issue. To investigate further, we need a minimal reproduction repository. Once you have the repository ready, please share the link here. |
@jakex7 I spun up a minimal repro here: https://github.com/ryanlntn/SVGMacOSRepro |
@jakex7 I was able to get this compiling for macOS with new arch using this patch. If that seems like a reasonable approach I'd be happy to open a PR. |
# Summary Based on recommendations from this [proposition](#2192 (comment)) and added some changes now we can build macOS using the new architecture. ## Compatibility | OS | Implemented | | ------- | :---------: | | macOS | ✅ | --------- Co-authored-by: Maciej Stosio <[email protected]>
Hello @ryanlntn, Thank you for your advice regarding the patch. We followed your suggestion and created a PR that has already been merged. If you have the time, we would appreciate it if you could test it based on the main branch. Thank you. |
Hi, @bohdanprog! I know this is already closed but just wanted to let you know that the latest version works on the project that I'm working on with @ryanlntn. Thank you so much! |
Bug
RNSVG fails to build on macOS when
RCT_NEW_ARCH_ENABLED
.Unexpected behavior
The build fails with
Property 'center' not found on object of type 'RNSVGUse *'
in RNSVGUse.mm. This doesn't happen with iOS builds or without the new arch enabled.Environment info
React native info output:
Library version: main
Steps To Reproduce
Issues without reproduction steps or code are likely to stall.
Describe what you expected to happen:
The text was updated successfully, but these errors were encountered: