Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: update Reanimated 4 docs #6931

Merged
merged 13 commits into from
Jan 24, 2025

Conversation

kacperkapusciak
Copy link
Member

This PR updates Reanimated 4 documentation:

  • updates installation steps in Getting Started
  • removes paper-example mentions from Contributing
  • documents textShadow style props behavior

Copy link
Member

@MatiPl01 MatiPl01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few remarks here, mostly related to the text-shadow documentation.

I would like you to add similar docs for the box-shadow property. Also, I would prefer to mark these docs as web-only because iOS works without any caveats and Android doesn't work at all with most of these props.

@kacperkapusciak
Copy link
Member Author

Documented box shadow styles as well

Copy link
Member

@MatiPl01 MatiPl01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a few small remarks, but, in general, shadow examples are much better now. Good job!

@kacperkapusciak kacperkapusciak added this pull request to the merge queue Jan 24, 2025
Merged via the queue into main with commit 4e47778 Jan 24, 2025
9 checks passed
@kacperkapusciak kacperkapusciak deleted the @kacperkapusciak/update-reanimated-4-beta-docs branch January 24, 2025 14:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants