Address comments

Author: ddoktorski

Cargo.lock

@@ -4,6 +4,6 @@ version = "0.1.0"
 edition = "2024"
 
 [dependencies]
-dap = { git = "https://github.com/software-mansion-labs/dap-rs", branch = "debugger-poc" }
+dap = { git = "https://github.com/software-mansion-labs/dap-rs", rev = "4440a6f" }
 tracing = "0.1"
 anyhow = "1.0"

Cargo.toml

@@ -15,16 +15,11 @@ pub struct Connection {
     inbound_rx: mpsc::Receiver<Request>,
     outbound_tx: mpsc::Sender<Sendable>,
 
-    // NOTE: The order matters here.
+    // NOTE: The order of members matters here.
     // I/O threads must be dropped after the channels.
     _io_threads: IoThreads,
 }
 
-struct IoThreads {
-    pub reader: Option<JoinHandle<()>>,
-    pub writer: Option<JoinHandle<()>>,
-}
-
 impl Connection {
     pub fn new() -> Result<Self> {
         let tcp_listener = TcpListener::bind("127.0.0.1:0").map_err(ServerError::IoError)?;
@@ -49,7 +44,7 @@ impl Connection {
     }
 
     pub fn next_request(&self) -> Result<Request> {
-        self.inbound_rx.recv().context("Connection close")
+        self.inbound_rx.recv().context("Inbound connection closed")
     }
 
     pub fn send_event(&self, event: Event) -> Result<()> {
@@ -71,6 +66,11 @@ impl Connection {
     }
 }
 
+struct IoThreads {
+    pub reader: Option<JoinHandle<()>>,
+    pub writer: Option<JoinHandle<()>>,
+}
+
 impl IoThreads {
     fn spawn(
         server_reader: ServerReader<TcpStream>,
@@ -119,7 +119,7 @@ fn spawn_writer_thread(
                 Sendable::Event(event) => {
                     server_writer.send_event(event).expect("Failed to send event")
                 }
-                Sendable::ReverseRequest(_) => unreachable!(),
+                Sendable::ReverseRequest(_) => unreachable!("Reverse requests are not supported"),
             }
         }
     })