New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feedback lab 1 #2

Open

ana-oprescu opened this issue Sep 20, 2017 · 0 comments

ana-oprescu commented Sep 20, 2017

Exercise 1	Comments	Exercise 2	Comments	Exercise 3	Comments	Exercise 4	Comments	Exercise 5	Comments	Exercise 6	Comments	Exercise 7	Comments	Exercise 8	Comments	Bonus Exercise 9	Comments	Bonus Exercise 10	Comments	Total

5	Code does not compile, without modyfing it. No quickcheck call provided	7	You are not checking mathematical facts	6	Timing should be per exercise, second answer just highlights the obvious. Missing quickcheck call	6	Function testing is missing	9	Solution is correct, but discussion about testing insufficient	9	Code can be more efficient.To much calls of prime_list. Requested was a counter example not a list of primes.	8	testcases could have been automatically generated; could have added testable properties for helper functions	9	-> issues		0		0	7.375

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment