Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feedback Lab 1 #3

Open
ana-oprescu opened this issue Sep 20, 2017 · 1 comment
Open

Feedback Lab 1 #3

ana-oprescu opened this issue Sep 20, 2017 · 1 comment

Comments

@ana-oprescu
Copy link

Exercise 1 Comments Exercise 2 Comments Exercise 3 Comments Exercise 4 Comments Exercise 5 Comments Exercise 6 Comments Exercise 7 Comments Exercise 8 Comments Bonus Exercise 9 Comments Bonus Exercise 10 Comments Total
6 Not quickCheck test implemented, no timing, no discussion about why the solution was selected 6 no timing, no quickcheck test provided, no discussion, answer not entirely correct, you are not testing mathematical fact 7 no timing, no quickcheck test provided, no discussion 6 no timing, no discussion neither testing provided 6 no timing, no discussion neither testing provided 10 Perfect 5 missing required tests for isCardType 9 -> issues 7 ok 5 nice implementation for Euler 10; unconvincing Euler 49; lots of compilation problems, due to implicit imports 7.475
@visknut
Copy link
Contributor

visknut commented Sep 20, 2017

I have two comments on recurring points of feedback for most of the exercises.

  • We wrote the required time for each exercise in the individual files, since it took us all a different amount of time to do each exercise. We didn’t know only the group files were relevant. Starting with lab 3, we’ll make sure that this data can also be found in the group files.
  • We designed the test functions so that they can all be tested with ‘quickCheck functionName’, instead of using quickCheck in our functions. Nowhere in the assignment is specified that a “quickCheck test” is a test using quickCheck, instead of a test designed for quickCheck. We choose the latter approach, because there are a lot arguments for quickCheck that you might want change/play around with while testing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants