Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feedback Lab 6 #23

Open
ana-oprescu opened this issue Oct 23, 2017 · 0 comments
Open

Feedback Lab 6 #23

ana-oprescu opened this issue Oct 23, 2017 · 0 comments

Comments

@ana-oprescu
Copy link

Exercise 1 Comments Exercise 2 Comments Exercise 3 Comments Exercise 4 Comments Exercise 5 Comments Exercise 6 Comments Exercise 7 Comments Exercise 8 Comments Total
9 Good job. Maybe a faster version could be implemented using Data.Bits.shiftR 9 It is not 10 just because you did not present a statistical validation with your tests. The rest is great 9 Why not starting in 4? Since you know that 2 and 3 are not composite 8 Implementation is great. However, you are not answering to what happens when K is increased to bigger numbers (>10) 5 Analysis is kind of short. In your tests/analysis you are not taking into account that a Carmichael number N fools the Fermat test if you check aˆ(N−1) for some a that is coprime with N. An analysis/test on that direction is needed 4 ->issues 4 ->issues 8 ->issues 7.657142857
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant