Skip to content

Conversation

@bakpaul
Copy link
Contributor

@bakpaul bakpaul commented Jun 24, 2025

This allow to have a global mechanism to enforce custom output directories for build and install tree.
This helps the process of integration SOFA in other projects that are not putting stuffs in the same place as us, especially, you guessed it: Slicer3D.

Now the question, do we want this for SOFA as it might be useful in the future, or we don't ? I'll continue the Todo's once it has been decided.

The PR made on the plugins introduces an "environment.cmake" file for some of them, or used an existing one to fix out-of-tree compilation.

This can actually be breaking for all plugins where I didn't add this, so here is the todo list:

  • test OOT compilation
  • test binaries generation --> this will be cumbersome because the paths are hard-coded in the post-install-fixup scprits.

[ci-depends-on https://github.com/SofaDefrost/ModelOrderReduction/pull/166]
[ci-depends-on https://github.com/sofa-framework/Sofa.Qt/pull/12]
[ci-depends-on https://github.com/sofa-framework/BeamAdapter/pull/197]
[ci-depends-on https://github.com/sofa-framework/SofaGLFW/pull/206]
[ci-depends-on https://github.com/SofaDefrost/SoftRobots/pull/334]
[ci-depends-on https://github.com/SofaDefrost/STLIB/pull/132]
[ci-depends-on https://github.com/sofa-framework/SofaPython3/pull/506]
[ci-depends-on https://github.com/sofa-framework/SofaPython3/pull/506]


By submitting this pull request, I acknowledge that
I have read, understand, and agree SOFA Developer Certificate of Origin (DCO).


Reviewers will merge this pull-request only if

  • it builds with SUCCESS for all platforms on the CI.
  • it does not generate new warnings.
  • it does not generate new unit test failures.
  • it does not generate new scene test failures.
  • it does not break API compatibility.
  • it is more than 1 week old (or has fast-merge label).

@bakpaul
Copy link
Contributor Author

bakpaul commented Jun 24, 2025

[ci-build][with-all-tests][force-full-build]

@sofabot
Copy link
Collaborator

sofabot commented Jun 24, 2025

[ci-depends-on] detected during build #2.

To unlock the merge button, you must

@sofabot
Copy link
Collaborator

sofabot commented Jun 25, 2025

[ci-depends-on] detected during build #3.

To unlock the merge button, you must

@bakpaul
Copy link
Contributor Author

bakpaul commented Jun 29, 2025

[ci-build][with-all-tests][force-full-build]

@sofabot
Copy link
Collaborator

sofabot commented Jun 29, 2025

[ci-depends-on] detected during build #4.

To unlock the merge button, you must

@hugtalbot hugtalbot changed the title [CMake] Clean CMake lists to be able to enfore global configuration of output folders [CMake] Clean CMake lists to be able to enforce global configuration of output folders Jul 2, 2025
@hugtalbot hugtalbot added pr: status wip Development in the pull-request is still in progress and removed pr: status to review To notify reviewers to review this pull-request labels Jul 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pr: experimental Demonstrate an experimental feature pr: project-ci-infrastructure pr: status wip Development in the pull-request is still in progress

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants