-
Notifications
You must be signed in to change notification settings - Fork 339
[CMake] Clean CMake lists to be able to enforce global configuration of output folders #5558
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
bakpaul
wants to merge
4
commits into
sofa-framework:master
Choose a base branch
from
bakpaul:25_06_parametrize_cmake_install_directories
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
[CMake] Clean CMake lists to be able to enforce global configuration of output folders #5558
bakpaul
wants to merge
4
commits into
sofa-framework:master
from
bakpaul:25_06_parametrize_cmake_install_directories
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jun 24, 2025
|
[ci-build][with-all-tests][force-full-build] |
|
[ci-depends-on] detected during build #2. To unlock the merge button, you must
|
|
[ci-depends-on] detected during build #3. To unlock the merge button, you must
|
|
[ci-build][with-all-tests][force-full-build] |
|
[ci-depends-on] detected during build #4. To unlock the merge button, you must
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
pr: experimental
Demonstrate an experimental feature
pr: project-ci-infrastructure
pr: status wip
Development in the pull-request is still in progress
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allow to have a global mechanism to enforce custom output directories for build and install tree.
This helps the process of integration SOFA in other projects that are not putting stuffs in the same place as us, especially, you guessed it: Slicer3D.
Now the question, do we want this for SOFA as it might be useful in the future, or we don't ? I'll continue the Todo's once it has been decided.
The PR made on the plugins introduces an "environment.cmake" file for some of them, or used an existing one to fix out-of-tree compilation.
This can actually be breaking for all plugins where I didn't add this, so here is the todo list:
[ci-depends-on https://github.com/SofaDefrost/ModelOrderReduction/pull/166]
[ci-depends-on https://github.com/sofa-framework/Sofa.Qt/pull/12]
[ci-depends-on https://github.com/sofa-framework/BeamAdapter/pull/197]
[ci-depends-on https://github.com/sofa-framework/SofaGLFW/pull/206]
[ci-depends-on https://github.com/SofaDefrost/SoftRobots/pull/334]
[ci-depends-on https://github.com/SofaDefrost/STLIB/pull/132]
[ci-depends-on https://github.com/sofa-framework/SofaPython3/pull/506]
[ci-depends-on https://github.com/sofa-framework/SofaPython3/pull/506]
By submitting this pull request, I acknowledge that
I have read, understand, and agree SOFA Developer Certificate of Origin (DCO).
Reviewers will merge this pull-request only if