Skip to content
This repository has been archived by the owner on Jul 10, 2023. It is now read-only.

Taxonomy menu name isn't using the "has_many" value. #24

Open
stevedsross opened this issue Jan 7, 2020 · 3 comments
Open

Taxonomy menu name isn't using the "has_many" value. #24

stevedsross opened this issue Jan 7, 2020 · 3 comments

Comments

@stevedsross
Copy link

When registering a custom taxonomy, the text used in the menu simply adds an "s" to the end of the singular name. It should use the "has_many" value for this, like the post type.

  "labels": {
    "has_one": "Industry",
    "has_many": "Industries",
    "text_domain": "sage"
  },

The example yields "Industrys" as the menu name.

@budimanfajarf
Copy link

Me too, any solution?

@darrenjacoby
Copy link
Member

@budimanfajarf @stevebrinston I will look into this!

If you happen to be using Intervention, I would recommend upgrading to 2.0.0-RC (which is due for an official release any day now) and register custom post types using that. It will likely be more heavily supported going forward.

@stevedsross
Copy link
Author

Not a fix, but a workaround. Overrides -> menu_name was missing from taxonomy-all.json. While it should be using the has_many label for the menu name like the custom post type, we can define the menu_name the same.

  "labels": {
    "has_one": "Industry",
    "has_many": "Industries",
    "text_domain": "sage",
    "overrides": {
      "menu_name": "Industries"
    }
  },

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants