Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add possibility to manually select Extraction zones #41

Open
simontorres opened this issue Mar 14, 2017 · 9 comments
Open

Add possibility to manually select Extraction zones #41

simontorres opened this issue Mar 14, 2017 · 9 comments
Assignees
Labels
enhancement high priority Task that are requied soon
Milestone

Comments

@simontorres
Copy link
Member

In some very special cases there might happen that the automatic target identification and extraction will not work properly, so there should exist the possibility to, by parsing an argument (most likely), manually select the regions for the target and for background subtraction.
This could be particularly helpful for targets that are too close or too close to the border (nobody should put their science target near the border though).

@b1quint
Copy link
Member

b1quint commented Mar 15, 2017

Isn't this related to #1?

@simontorres
Copy link
Member Author

Absolutely, but I think this can be treated independently because one thing is to improve the target detection (automatically) and another is to add a manual option (similar to the interactive mode for wavelength calibration). Despite this I would consider merging both issues. By the way, this came out from the discussion after the talk in the SOAR 2020 Workshop.

@b1quint
Copy link
Member

b1quint commented Mar 15, 2017

This is one of the reasons that it has to be considered for the object extraction: if an input from the user may be an option, we have to have the code written to make this available in the future. If not, it may be too entangled so adding this new capability will be much more difficult.

@simontorres simontorres modified the milestone: Beta Version Mar 16, 2017
@cbaorion
Copy link
Collaborator

Yes, we definitely want this feature! Simon should code things so that this can be added later, but I would not include it for the Beta release.

@simontorres
Copy link
Member Author

It will require some time, since we need to program a graphic user interface for this but if we are planning to create a special library for graphic treatment (see #42 )we better leave the effort for then.

@simontorres
Copy link
Member Author

I'm currently having this issue with data that contains an extended source. Usually the background subtraction zone is selected an n-sigmas apart from the edge of the target extraction zone. What usually works for point sources does not work for extended sources Such as a planetary nebula (LEFT)
background-extended-source
At least there should be a command line argument that allows to adjust the separation of the background zone.

@simontorres simontorres mentioned this issue May 22, 2018
@simontorres simontorres mentioned this issue Jul 12, 2018
1 task
@simontorres
Copy link
Member Author

Could this be a solution for #13 ?
Not for fully automatic.

@simontorres
Copy link
Member Author

related #298

@simontorres
Copy link
Member Author

Upon review with @Allonck we think that despite this issue being very old it is still a desired feature in 2024.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement high priority Task that are requied soon
Projects
None yet
Development

No branches or pull requests

3 participants