Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug that causes to load compatible but not the best possible comparison lamp #357

Open
simontorres opened this issue Jun 10, 2021 · 0 comments
Labels

Comments

@simontorres
Copy link
Member

Consider the following data:
Those lamps are a called a COMP Group and the the are grouped together because several keyword values are the same, among those there are radeg and decdeg which are the degree version of obsra and obsdec respectively.

         obsra        obsdec       grating  cam_targ  ...     filter filter2  gain  rdnoise  lamp_hga lamp_ne lamp_ar lamp_fe lamp_cu      radeg    decdeg
12:27:25.776  11:06:28.148  600_SYZY_OLD      20.0  ...  NO_FILTER   GG395  2.06     3.99     FALSE   FALSE   FALSE   FALSE    TRUE  186.85740  11.10782
12:27:25.776  11:06:28.148  600_SYZY_OLD      20.0  ...  NO_FILTER   GG395  2.06     3.99      TRUE    TRUE   FALSE   FALSE   FALSE  186.85740  11.10782
12:27:25.776  11:06:28.148  600_SYZY_OLD      20.0  ...  NO_FILTER   GG395  2.06     3.99      TRUE    TRUE   FALSE   FALSE   FALSE  186.85740  11.10782
12:27:25.776  11:06:28.148  600_SYZY_OLD      20.0  ...  NO_FILTER   GG395  2.06     3.99     FALSE   FALSE   FALSE   FALSE    TRUE  186.85740  11.10782
12:27:25.776  11:06:28.148  600_SYZY_OLD      20.0  ...  NO_FILTER   GG395  2.06     3.99      TRUE    TRUE   FALSE   FALSE   FALSE  186.85740  11.10782

The problem is that radeg and decdeg have a precision of two decimals and this leads to combine in the same group lamps that should be in a different one but since they are for the same target but taken at different moment they will no provide the best possible wavelength solution.

The solution is to increase the precision to 6 decimals.

simontorres added a commit to simontorres/goodman_pipeline that referenced this issue Aug 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant