Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ListT should be deprecated #203

Open
ocramz opened this issue Nov 8, 2021 · 1 comment
Open

ListT should be deprecated #203

ocramz opened this issue Nov 8, 2021 · 1 comment

Comments

@ocramz
Copy link

ocramz commented Nov 8, 2021

Getting deprecation warnings when compiling with GHC 8.10.7

mono-traversable      > /private/var/folders/jt/62x9h30j52qbj_r1t6708mx40000gn/T/stack-8f5626c1176b4af3/mono-traversable-1.0.15.3/src/Data/MonoTraversable.hs:213:36: warning: [-Wdeprecations]
mono-traversable      >     In the use of type constructor or class ‘ListT’
mono-traversable      >     (imported from Control.Monad.Trans.List):
mono-traversable      >     Deprecated: "This transformer is invalid on most monads"
mono-traversable      >     |   
mono-traversable      > 213 | instance Functor m => MonoFunctor (ListT m a)
mono-traversable      >     |                                    ^^^^^
mono-traversable      >         
mono-traversable      > /private/var/folders/jt/62x9h30j52qbj_r1t6708mx40000gn/T/stack-8f5626c1176b4af3/mono-traversable-1.0.15.3/src/Data/MonoTraversable.hs:793:40: warning: [-Wdeprecations]
mono-traversable      >     In the use of type constructor or class ‘ListT’
mono-traversable      >     (imported from Control.Monad.Trans.List):
mono-traversable      >     Deprecated: "This transformer is invalid on most monads"
mono-traversable      >     |   
mono-traversable      > 793 | instance F.Foldable f => MonoFoldable (ListT f a)
mono-traversable      >     |                                        ^^^^^
mono-traversable      >         
mono-traversable      > /private/var/folders/jt/62x9h30j52qbj_r1t6708mx40000gn/T/stack-8f5626c1176b4af3/mono-traversable-1.0.15.3/src/Data/MonoTraversable.hs:1056:44: warning: [-Wdeprecations]
mono-traversable      >     In the use of type constructor or class ‘ListT’
mono-traversable      >     (imported from Control.Monad.Trans.List):
mono-traversable      >     Deprecated: "This transformer is invalid on most monads"
mono-traversable      >      |  
mono-traversable      > 1056 | instance Traversable f => MonoTraversable (ListT f a)
@andreasabel
Copy link
Collaborator

I suppose the end-user of ListT will also get such warnings. If they choose to ignore them, they should still be able to mono-traverse ListT.
I would think it is sufficient to remove support for ListT once it is actually removed upstream (rather than just being deprecated).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants