From f24bf483914931d4de949cf760ae8218d76991c4 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Piotr=20Poniedzia=C5=82ek?= <pondzix@gmail.com>
Date: Wed, 10 Jan 2024 12:28:50 +0100
Subject: [PATCH] Use only version for `_schema_version` context field (close
 #134)

---
 .../SnowplowEvent.scala                       |  2 +-
 .../EventSpec.scala                           | 22 +++++++++----------
 2 files changed, 12 insertions(+), 12 deletions(-)

diff --git a/src/main/scala/com.snowplowanalytics.snowplow.analytics.scalasdk/SnowplowEvent.scala b/src/main/scala/com.snowplowanalytics.snowplow.analytics.scalasdk/SnowplowEvent.scala
index db2c4e3..f3e1a12 100644
--- a/src/main/scala/com.snowplowanalytics.snowplow.analytics.scalasdk/SnowplowEvent.scala
+++ b/src/main/scala/com.snowplowanalytics.snowplow.analytics.scalasdk/SnowplowEvent.scala
@@ -69,7 +69,7 @@ object SnowplowEvent {
   }
 
   private def addSchemaVersionToData(contextSdd: SelfDescribingData[Json]): Json = {
-    val version = Json.obj("_schema_version" -> contextSdd.schema.toSchemaUri.asJson)
+    val version = Json.obj("_schema_version" -> contextSdd.schema.version.asString.asJson)
     contextSdd.data.deepMerge(version)
   }
 
diff --git a/src/test/scala/com.snowplowanalytics.snowplow.analytics.scalasdk/EventSpec.scala b/src/test/scala/com.snowplowanalytics.snowplow.analytics.scalasdk/EventSpec.scala
index 37d126c..aa4c15d 100644
--- a/src/test/scala/com.snowplowanalytics.snowplow.analytics.scalasdk/EventSpec.scala
+++ b/src/test/scala/com.snowplowanalytics.snowplow.analytics.scalasdk/EventSpec.scala
@@ -233,7 +233,7 @@ class EventSpec extends Specification with ScalaCheck {
         "mkt_content" : null,
         "mkt_campaign" : null,
         "contexts_org_schema_web_page_1" : [ {
-          "_schema_version" : "iglu:org.schema/WebPage/jsonschema/1-0-0",
+          "_schema_version" : "1-0-0",
           "genre" : "blog",
           "inLanguage" : "en-US",
           "datePublished" : "2014-11-06T00:00:00Z",
@@ -242,7 +242,7 @@ class EventSpec extends Specification with ScalaCheck {
           "keywords" : [ "snowplow", "javascript", "tracker", "event" ]
         } ],
         "contexts_org_w3_performance_timing_1" : [ {
-          "_schema_version" : "iglu:org.w3/PerformanceTiming/jsonschema/1-0-0",
+          "_schema_version" : "1-0-0",
           "navigationStart" : 1415358089861,
           "unloadEventStart" : 1415358090270,
           "unloadEventEnd" : 1415358090287,
@@ -338,7 +338,7 @@ class EventSpec extends Specification with ScalaCheck {
         "refr_domain_userid" : null,
         "refr_dvce_tstamp" : null,
         "contexts_com_snowplowanalytics_snowplow_ua_parser_context_1": [{
-          "_schema_version" : "iglu:com.snowplowanalytics.snowplow/ua_parser_context/jsonschema/1-0-0",
+          "_schema_version" : "1-0-0",
           "useragentFamily": "IE",
           "useragentMajor": "7",
           "useragentMinor": "0",
@@ -681,7 +681,7 @@ class EventSpec extends Specification with ScalaCheck {
         "mkt_content" : null,
         "mkt_campaign" : null,
         "contexts_org_schema_web_page_1" : [ {
-          "_schema_version" : "iglu:org.schema/WebPage/jsonschema/1-0-0",
+          "_schema_version" : "1-0-0",
           "genre" : "blog",
           "inLanguage" : "en-US",
           "datePublished" : "2014-11-06T00:00:00Z",
@@ -691,11 +691,11 @@ class EventSpec extends Specification with ScalaCheck {
         } ],
         "contexts_org_acme_context_one_1" : [
           {
-            "_schema_version" : "iglu:org.acme/context_one/jsonschema/1-0-0",
+            "_schema_version" : "1-0-0",
             "item" : 1
           },
           {
-            "_schema_version" : "iglu:org.acme/context_one/jsonschema/1-0-1",
+            "_schema_version" : "1-0-1",
             "item" : 2
           }
         ],
@@ -773,7 +773,7 @@ class EventSpec extends Specification with ScalaCheck {
         "refr_domain_userid" : null,
         "refr_dvce_tstamp" : null,
         "contexts_com_snowplowanalytics_snowplow_ua_parser_context_1": [{
-          "_schema_version" : "iglu:com.snowplowanalytics.snowplow/ua_parser_context/jsonschema/1-0-0",
+          "_schema_version" : "1-0-0",
           "useragentFamily": "IE",
           "useragentMajor": "7",
           "useragentMinor": "0",
@@ -816,7 +816,7 @@ class EventSpec extends Specification with ScalaCheck {
         "contexts_org_schema_web_page_1" ->
           List(
             JsonObject(
-              ("_schema_version", "iglu:org.schema/WebPage/jsonschema/1-0-0".asJson),
+              ("_schema_version", "1-0-0".asJson),
               ("genre", "blog".asJson),
               ("inLanguage", "en-US".asJson),
               ("datePublished", "2014-11-06T00:00:00Z".asJson),
@@ -828,11 +828,11 @@ class EventSpec extends Specification with ScalaCheck {
         "contexts_org_acme_context_one_1" ->
           List(
             JsonObject(
-              ("_schema_version", "iglu:org.acme/context_one/jsonschema/1-0-0".asJson),
+              ("_schema_version", "1-0-0".asJson),
               ("item", 1.asJson)
             ).asJson,
             JsonObject(
-              ("_schema_version", "iglu:org.acme/context_one/jsonschema/1-0-1".asJson),
+              ("_schema_version", "1-0-1".asJson),
               ("item", 2.asJson)
             ).asJson
           ).asJson
@@ -841,7 +841,7 @@ class EventSpec extends Specification with ScalaCheck {
         "contexts_com_snowplowanalytics_snowplow_ua_parser_context_1" ->
           List(
             JsonObject(
-              ("_schema_version", "iglu:com.snowplowanalytics.snowplow/ua_parser_context/jsonschema/1-0-0".asJson),
+              ("_schema_version", "1-0-0".asJson),
               ("useragentFamily", "IE".asJson),
               ("useragentMajor", "7".asJson),
               ("useragentMinor", "0".asJson),