From af67a379b704aa0567115a7b65d32db4725d5ec3 Mon Sep 17 00:00:00 2001
From: Antonio Costa <a.costa@trikorasolutions.com>
Date: Tue, 7 Nov 2023 12:32:11 +0100
Subject: [PATCH] feat: the auto_floating_ip is now a parameter that defaults
 to false

---
 roles/openstack_vm/README.md           | 3 ++-
 roles/openstack_vm/defaults/main.yml   | 1 +
 roles/openstack_vm/tasks/vm_create.yml | 2 +-
 3 files changed, 4 insertions(+), 2 deletions(-)

diff --git a/roles/openstack_vm/README.md b/roles/openstack_vm/README.md
index 3bf58e4..c14cd9b 100644
--- a/roles/openstack_vm/README.md
+++ b/roles/openstack_vm/README.md
@@ -18,7 +18,7 @@ collections:
 
 ## Role Variables
 
-OpenStack VM role required parameters
+OpenStack VM role parameters
 
 | Parameter | Comments   |
 |-----------|------------|
@@ -27,6 +27,7 @@ OpenStack VM role required parameters
 | `openstack_security_group` <br/>$\color{fuchsia}{\textsf{map}}$ / $\color{red}{\textsf{required}}$ | Security group |
 | `state` <br/>$\color{fuchsia}{\textsf{map}}$ / $\color{red}{\textsf{required}}$ | State of the VM <br/> * `present` <br/> * `absent` |
 | `vm_name` <br/>$\color{fuchsia}{\textsf{map}}$ / $\color{red}{\textsf{required}}$ | Name of the VM to be created |
+| `openstack_vm_auto_floating_ip` <br/>$\color{fuchsia}{\textsf{string}}$ | Auto associate a Floating IP <br/> * **`false` <= Default** <br/> * `true` |
 
 <sup>1)</sup> More information on the available keystone plugins on the 
 [RHOS documentation](https://docs.openstack.org/keystoneauth/latest/plugin-options.html#available-plugins).
diff --git a/roles/openstack_vm/defaults/main.yml b/roles/openstack_vm/defaults/main.yml
index c409a08..15af603 100644
--- a/roles/openstack_vm/defaults/main.yml
+++ b/roles/openstack_vm/defaults/main.yml
@@ -48,3 +48,4 @@ openstack_defaults:
 
 # login_username: centos
 openstack_security_group: spring-boot
+openstack_vm_auto_floating_ip: false
diff --git a/roles/openstack_vm/tasks/vm_create.yml b/roles/openstack_vm/tasks/vm_create.yml
index 6995ccd..2c16ffa 100644
--- a/roles/openstack_vm/tasks/vm_create.yml
+++ b/roles/openstack_vm/tasks/vm_create.yml
@@ -81,7 +81,7 @@
       state: "{{ state }}"
       timeout: "{{ openstack.timeout | default(openstack_defaults.timeout) }}"
       flavor: "{{ openstack.vm.flavor }}"
-      auto_floating_ip: yes
+      auto_floating_ip: "{{ openstack_vm_auto_floating_ip }}"
       network: "{{ openstack.vm.network | default('') }}"
       security_groups: "{{ openstack_security_group }}"
       boot_from_volume: "{{ openstack.vm.boot_from_volume | default(false) }}"