-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Regex support added for ignore URL list in settings.py #116
base: main
Are you sure you want to change the base?
Conversation
@ingvaldlorentzen @JonasKs @nschlemm Can you please review workflows for Django Version 5.0 above. |
Thanks for the PR! The code needs tests, and I'd like to use a |
@JonasKs Thanks for your recommendations. Followed this - The code needs tests, and I'd like to use a re.compile solution instead of this. Inspiration can be found here Updates:
Please have a look on the Django 5.0 workflows. |
@JonasKs @nschlemm @ingvaldlorentzen Can you please review the PR. |
I'll get to it when I have time. I won't have time until next week at earliest. |
@JonasKs No issues. Check this as per your convenience. Thanks 👍 |
Wow, I definitely didn't intend to just close this out of nowhere. I was looking for this now, and couldn't find it. @sauravsharma1998 , I'm sorry. |
The implementation would be a breaking change - since you change the current |
IGNORE_URLS = [] | ||
for url in settings.ignore_urls: | ||
url_regex = url.replace('*', r'[\s\S]*') # noqa | ||
url_regex = '^' + url_regex + '$' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If we make this a new setting, e.g. ignore_url_regex
, we can also skip this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@JonasKs Thanks for the suggestions. I have moved it to a new settings. But facing errors in CI pipeline.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I’m on vacation, but I’ll check when I’m back. 😊
There's failing pipelines, even though I haven't changed anything and I've deleted all caches.. I'll have to look further into this, but I'm not sure what's happening. |
Regex Support Added for IGNORE_URLS:
admin/* [All URL pattern with starting with admin/ will be ignored for GUID generation]
Suggestion Link: #104