Add the ability to customize the log record field name for correlation ids. #115
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NiklasBeierl
force-pushed
the
custom_log_field
branch
2 times, most recently
from
3010417
to
9e42cb4
Compare
NiklasBeierl
force-pushed
the
custom_log_field
branch
from
9e42cb4
to
659e0e2
Compare
|
Hey @JonasKs @sondrelg @ingvaldlorentzen is snok still invested in maintaining this package? |
|
Wow - I never saw this. |
One of those long weekends again. 😝 (No offense, I know what it's like! 😆) |
|
You're right, sorry. Life's busy these days. LGTM! |
|
I've pushed a new release, should be out in a few mins. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
I use elastic common schema for the logs of my django application (with
ecs-logging). ECS dictates the use ofhttp.request.idas the field name for request ids. At the moment I use an an additional filter that moves the field formcorrelation_idtohttp.request.id, but I figured it is much cleaner to choose the field name here and other people might also find this usefull. Very neat package btw, thx!