Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

apply branch protection rules #108

Closed
plastikfan opened this issue Mar 6, 2023 · 2 comments · Fixed by #112
Closed

apply branch protection rules #108

plastikfan opened this issue Mar 6, 2023 · 2 comments · Fixed by #112
Assignees
@plastikfan
Labels
chore Non source related, infrasture change

Comments

@plastikfan
Copy link
Contributor

plastikfan commented Mar 6, 2023 •
edited
Loading

Require Pull Request(master)

  • also ensure Do not allow bypassing the above settings is set
  • change the ci workflow to trigger on pull requests only
@plastikfan plastikfan added the chore Non source related, infrasture change label Mar 6, 2023
@plastikfan plastikfan self-assigned this Mar 6, 2023
@plastikfan
Copy link
Contributor Author

With this rule in place, start using the Rebase and Merge option. This will ensure flat history

@plastikfan
Copy link
Contributor Author

plastikfan commented Mar 6, 2023 •
edited
Loading

Also instead of using the endflow function (which for saftey reasons should either be renamed or deleted), we should now use an endfeat, which fetches from upstream.

stale local branches have to be deleted manually either using git fetch --prune or branch deletion with -D option

plastikfan added a commit that referenced this issue Mar 7, 2023
@plastikfan
chore: 🤚 ACTIVATE BRANCH PROTECTION RULES (#108)
d947f74
@plastikfan plastikfan pinned this issue Mar 7, 2023
@plastikfan plastikfan linked a pull request Mar 7, 2023 that will close this issue
chore: 🤚 ACTIVATE BRANCH PROTECTION RULES (#108) #112
Merged
plastikfan added a commit that referenced this issue Mar 7, 2023
@plastikfan
chore: 🤚 ACTIVATE BRANCH PROTECTION RULES (#108)
92e0aa9
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@plastikfan plastikfan

Labels
chore Non source related, infrasture change
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore: 🤚 ACTIVATE BRANCH PROTECTION RULES (#108) snivilised/extendio
1 participant
@plastikfan