Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AP: reject incoming DMs #886

Closed
snarfed opened this issue Feb 18, 2024 · 4 comments
Closed

AP: reject incoming DMs #886

snarfed opened this issue Feb 18, 2024 · 4 comments
Labels

Comments

@snarfed
Copy link
Owner

snarfed commented Feb 18, 2024

Bridgy Fed only handles fully public data, so it doesn't bridge DMs. It happily accepts them though, and then ignores them, which isn't great, since it means people can DM bridged users and have no idea their DMs didn't go through. We should return HTTP 501 Not Implemented or something similar to inbox deliveries of DMs.

@qazmlp
Copy link

qazmlp commented Mar 26, 2024

You'll also need to check how Fediverse software behaves if it receives that error. To my knowledge, Mastodon happily returns a 200 OK when receiving objects it does not support, and then silently ignores them. I don't think it will notify a user if it can't deliver an outbound object either.

Not saying that you shouldn't send a 501 Not Implemented since that's helpful for other software/in the future, but it may be a good idea to bounce back a reply-DM with instructions to only the sender.

@snarfed
Copy link
Owner Author

snarfed commented Mar 26, 2024

True! Mastodon and most other fediverse servers generally check signatures synchronously during inbox delivery requests, and then return 202 and do all other processing async, so sending servers don't see failures there. The idea here would be to return eg 501 synchronously, but you're right, I have no idea whether/how different servers would surface that to users, if at all.

@snarfed
Copy link
Owner Author

snarfed commented Apr 4, 2024

The more sophisticated approach here might be to send a DM back saying, "sorry, DMs aren't supported, feel free to send them that message another way."

@snarfed snarfed added the now label Jul 26, 2024
@snarfed
Copy link
Owner Author

snarfed commented Sep 8, 2024

Subsumed by #966 etc

@snarfed snarfed closed this as not planned Won't fix, can't repro, duplicate, stale Sep 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants