Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove verifyingContract from domain #464

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

pscott
Copy link
Contributor

@pscott pscott commented Jul 4, 2024

Summary

Removes verifyingContract from the starknet-authenticator domain. See #463 for context

Closes: #463

How to test

To-Do

  • [ ]

@pscott pscott requested a review from Sekhmet July 4, 2024 12:53
@pscott pscott force-pushed the feat_remove-verifyingContract branch from f59cbd2 to 443a475 Compare July 4, 2024 12:57
@pscott
Copy link
Contributor Author

pscott commented Jul 4, 2024

Running yarn test on my machine yields:

api-subgraph:test: 
$ graph test
$ tsc && tsc -p tsconfig.cjs.json
$ SEPOLIA_NODE_URL=https://rpc.snapshotx.xyz/11155111 vitest run test/unit
api-subgraph:test: Skipping download/install step because binary already exists at /Users/pscott/Code/Snapshot/sx-monorepo/node_modules/binary-install-raw/bin/0.6.0
api-subgraph:test: Error: spawnSync /Users/pscott/Code/Snapshot/sx-monorepo/node_modules/binary-install-raw/bin/0.6.0/binary-macos-12-m1 Unknown system error -88
api-subgraph:test:     at Object.spawnSync (node:internal/child_process:1117:20)
api-subgraph:test:     at spawnSync (node:child_process:876:24)
api-subgraph:test:     at Binary.run (/Users/pscott/Code/Snapshot/sx-monorepo/node_modules/binary-install-raw/index.js:111:20)
api-subgraph:test:     at TestCommand.runBinary (/Users/pscott/Code/Snapshot/sx-monorepo/node_modules/@graphprotocol/graph-cli/dist/commands/test.js:143:52) {
api-subgraph:test:   errno: -88,
api-subgraph:test:   code: 'Unknown system error -88',
api-subgraph:test:   syscall: 'spawnSync /Users/pscott/Code/Snapshot/sx-monorepo/node_modules/binary-install-raw/bin/0.6.0/binary-macos-12-m1',
api-subgraph:test:   path: '/Users/pscott/Code/Snapshot/sx-monorepo/node_modules/binary-install-raw/bin/0.6.0/binary-macos-12-m1',
api-subgraph:test:   spawnargs: []
api-subgraph:test: }

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat: remove verifyingContract from sn-sig auth
1 participant