Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Investigate if we can support null as snapshot on EVM networks #805

Open
Sekhmet opened this issue Sep 23, 2024 · 0 comments
Open

Investigate if we can support null as snapshot on EVM networks #805

Sekhmet opened this issue Sep 23, 2024 · 0 comments

Comments

@Sekhmet
Copy link
Member

Sekhmet commented Sep 23, 2024

Currently we enforce snapshot block to not be null on EVM:

if (snapshotInfo.at === null)
throw new Error('EVM requires block number to be defined');

I'm not longer sure why that's the case, quick look at EVM strategies suggests that it might actually work, just using blockTag: "latest" if block is null.

We should verify if that's possible and implement it so we don't have this extra logic inside.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant