diff --git a/src/addressResolvers/ens.ts b/src/addressResolvers/ens.ts index 95c3e944..bdbafec5 100644 --- a/src/addressResolvers/ens.ts +++ b/src/addressResolvers/ens.ts @@ -63,7 +63,10 @@ export async function resolveNames(handles: Handle[]): Promise { + return; + }, + () => { + describe('when passing an expired domain name', () => { + it('should ignore results for expired domains', () => { + return expect(resolveNames(['49415.eth'])).resolves.toEqual({}); + }); + }); + } ); diff --git a/test/unit/addressResolvers/helper.ts b/test/unit/addressResolvers/helper.ts index 4f5af131..935d236d 100644 --- a/test/unit/addressResolvers/helper.ts +++ b/test/unit/addressResolvers/helper.ts @@ -7,7 +7,13 @@ export default function testAddressResolver( validAddress, validDomain, blankAddress, - invalidDomains + invalidDomains, + extraLookupAddressesTests = () => { + return; + }, + extraResolveNamesTests = () => { + return; + } ) { describe(`${name} address resolver`, () => { describe('lookupAddresses()', () => { @@ -40,6 +46,8 @@ export default function testAddressResolver( ); }, 10e3); }); + + extraLookupAddressesTests(); }); describe('resolveNames()', () => { @@ -64,6 +72,8 @@ export default function testAddressResolver( }); }, 10e3); }); + + extraResolveNamesTests(); }); }); }